Messages

Thanks Julie, separate jars that developers can customise makes things easier.
- Clinton

Thanks Brian,
  I removed log4j-1.2.8.jar from our lib dir and redployed the konakart app - doesn't seem to have caused any problems, I'm still getting log messages as expected.

- Clinton

Thankyou Julie,
commenting out this block in Baseform.java got rid of the warning message:

/* try {
            request.setCharacterEncoding("UTF-8");
        } catch (UnsupportedEncodingException e) {
            e.printStackTrace();
        }
*/
Cheers,
  Clinton

Thanks Julie for your prompt reply,  I've checked a previous log from v2.2.0.6 and I've found one and only one previous occurence of this error:

[#|2007-10-09T12:24:07.866+1000|WARNING|sun-appserver-pe9.0|org.apache.coyote.tomcat5.CoyoteRequest|_ThreadID=12;_ThreadName=httpWorkerThread-4848-0;_RequestID=947bda24-c765-45fa-bada-0fdf3efec3f7;|Unable to set character encoding UTF-8 because request parameters have already been read, or ServletRequest.getReader() has been called|#]

What's different now is this error is occuring on what seems like every page transition.  I'm wondering if it's something we've done at this end, given we have our own custom build.  We have modified the web.xml as per my other post, the konakart.properties to refer to our own database, added some product images. 

- Clinton

In konakart (client) 2.2.07, the top of the web.xml looks like:

<?xml version="1.0" encoding="ISO-8859-1"?>
<!DOCTYPE web-app PUBLIC "-//Sun Microsystems, Inc.//DTD Web Application 2.2//EN"
  "http://java.sun.com/j2ee/dtds/web-app_2_2.dtd">;
<web-app>
   <display-name>KonaKart</display-name>
    <listener>
        <listener-class>org.apache.axis.transport.http.AxisHTTPSessionListener</listener-class>
    </listener>
...

This is a problem because the <listener> element is only defined in the 2.3 dtd. When we ran this under Glassfish, it generated parsing errors and refused to deploy the konakart app.

Altering the web.xml to use the following dtd solved the parsing error:

<!DOCTYPE web-app PUBLIC "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN" "http://java.sun.com/dtd/web-app_2_3.dtd">;

If your web.xml is validated you might run into a similar issue...

- Clinton

Does Konakart really need two different log4j jars in it's lib/ dir?
Not sure if it's problematic, but this could cause clashes/conflicts.

In 2.2.0.7 there is :

log4j-1.2.8.jar
log4j-1.2.12.jar

It would be reassuring to developers to see only one jar. Or at least understand why there are two.

Cheers,
  Clinton.

Hello,
  using the new 2.2.07 release, I have cobbled together my own konakart.war file using a custom ant build and deployed under Glassfish 9.0_01.

The app seems to work ok, but on each page transition (ie: navigation to a different page), Glassfish's server.log is reporting:

[#|2007-10-24T16:47:50.613+1000|WARNING|sun-appserver-pe9.0|org.apache.coyote.to
mcat5.CoyoteRequest|_ThreadID=16;_ThreadName=httpWorkerThread-8080-0;_RequestID=
ef381231-441e-4eeb-bc8a-8e8d5e490353;|Unable to set character encoding UTF-8 because request parameters have already been read, or ServletRequest.getReader() has been called|#]

Short of using a debugger or enabling struts debug, I'm not sure how to debug this further.  In this app I haven't deployed a log4j.properties yet.

Can anyone cast some light on why this warning might be occurring?

Thanks,
  Clinton.

Would it make things easier if the konakart-app.jar was split into two, with one jar containing non-customisable classes, whereas the second jar could contain all the Actions and Forms for which we currently have the source code?

Developers may want to provide their own customisations of the struts Actions and Forms, but currently these are bundled into konakart-app.jar alongside non-customisable classes.  This means developers wishing to customise the default Actions must either modify the jar, overriding classes as desired, or recreate/repackage the jar.  It could be a cleaner separation of concerns if we had a jar containing only customisable classes (ie: for which we have source code).